Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feedback/Rate Us section done ! #290 #345

Closed
wants to merge 1 commit into from
Closed

Add Feedback/Rate Us section done ! #290 #345

wants to merge 1 commit into from

Conversation

Subhajit-2023-44
Copy link
Contributor

@Subhajit-2023-44 Subhajit-2023-44 commented Oct 30, 2024

Hello, PR
Add Feedback/Rate Us section with star rating widget - #290
Done properly -

Untitled.video.-.Made.with.Clipchamp.-.2024-10-31T030904.269.mp4

Screenshot 2024-10-31 030545
Screenshot 2024-10-31 030554
Screenshot 2024-10-31 030611

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidlines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛
  • New feature (non-breaking change which adds functionality) ✨
  • UI enhancement (non-breaking change which enhances UI) 🎨
  • Documentation update 📚

@Subhajit-2023-44
Copy link
Contributor Author

@Harshdev098 sir done, please merge my PR with level 3, I also add a star rating widget with feedback form..

Thank You

@Subhajit-2023-44
Copy link
Contributor Author

@Harshdev098 sir

Copy link
Member

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make it more responsive

image

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Nov 1, 2024

I think you can make it more responsive

What ? Sir I didn't understand ...

@Harshdev098 sir i added everything what i can do, Feedback form, toast message & also star rating widget...

Screenshot 2024-10-31 030554

If you check other projects, they give level 2/3 for feedback form and level 2 for star rating and another level 2 for toast message but I added everything in this PR because tomorrow was the last day, so...

@Harshdev098 sir please merge my PR 🙏🏻

cursor: pointer;
margin-left: 183px;
margin-top: -33px; /* Add space above the button */
display: block; /* Ensure it takes the full width */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the display, flex and add some padding in x-axis of the i tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the display, flex and add some padding in x-axis of the i tag

😢okay wait i will give a new PR again

@Subhajit-2023-44 Subhajit-2023-44 closed this by deleting the head repository Nov 1, 2024
@Subhajit-2023-44
Copy link
Contributor Author

@Harshdev098 sir done #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants