-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rc_scratch references #392
Remove rc_scratch references #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of your changes look good. One thing I think we should change is that on the filesystems.md
page there are references to scratch
. It was previously written this way because there were separate scratch directories for Alpine and Blanca. I think we should change all of these references to /scratch/alpine
. For example, here is an occurrence of this:
I think this will hopefully reduce any confusion. Although I am sure people will still be confused that is says "alpine". If you think it is appropriate, you can turn the important admonition into a bullet list and the second bullet (or first) you can explain that Alpine and Blanca now share the same scratch directory and it is called /scratch/alpine
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good! I made one small suggestion on a comma that I think should be removed. If you don't think it should be removed, no worries you can resolve that conversation.
Co-authored-by: b-reyes <53541061+b-reyes@users.noreply.github.com>
Address issue #383