Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rc_scratch references #392

Merged

Conversation

jreiland
Copy link
Contributor

Address issue #383

@jreiland jreiland requested a review from b-reyes November 15, 2024 22:43
Copy link
Contributor

@b-reyes b-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of your changes look good. One thing I think we should change is that on the filesystems.md page there are references to scratch. It was previously written this way because there were separate scratch directories for Alpine and Blanca. I think we should change all of these references to /scratch/alpine. For example, here is an occurrence of this:
Screenshot 2024-11-15 at 4 00 32 PM

I think this will hopefully reduce any confusion. Although I am sure people will still be confused that is says "alpine". If you think it is appropriate, you can turn the important admonition into a bullet list and the second bullet (or first) you can explain that Alpine and Blanca now share the same scratch directory and it is called /scratch/alpine.

Copy link
Contributor

@b-reyes b-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! I made one small suggestion on a comma that I think should be removed. If you don't think it should be removed, no worries you can resolve that conversation.

docs/compute/filesystems.md Outdated Show resolved Hide resolved
Co-authored-by: b-reyes <53541061+b-reyes@users.noreply.github.com>
@jreiland jreiland merged commit 2050c4f into ResearchComputing:main Nov 18, 2024
1 check passed
@jreiland jreiland deleted the Remove-rc_scratch-references branch November 18, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants