-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction wrongly emphasizes file-based data; other types of data entity are also valid #125
Comments
Thanks for spotting this, @CaroleGoble - this text must have been left behind after we added #74 in RO-Crate 1.1 While I think the simple use case of organizing files should remain, which of course with #74 also can be remote "downloadable" data entities, but with #122 we would even semantically have an RO-Crate with no data entities at all, just a meaningful collection of contextual entities. How to identify and represent entries in a database is a bit unclear at the moment, perhaps we should make a separate issue for that.. there is a risk of indirection to indirection (do we really want an entity of Do we have a concrete use case for referencing database record that we could formalize, perhaps from SYNTHESYS+? |
@CaroleGoble I'll take a look at this. What's FDO? |
@stain - what's the procedure for starting work on an update 1.1x? I assume that is if this is as important as @CaroleGoble's language suggests that we want to do a rapid patch-release on 1.1 rather than wait for 1.2? |
FDO = FAIR Digital Object . https://fairdo.org/ https://datascience.codata.org/articles/10.5334/dsj-2020-015/ doesn't exist as an implementation, politically important. https://drive.google.com/drive/u/0/folders/1nRSErRp_x7qRXDpfHWssdK1CzefuegVo |
@CaroleGoble I had a go at rewording that intro part. It's on a branch here: https://github.com/ResearchObject/ro-crate/blob/bug-intro-issue-125/docs/1.1/introduction.md What do you think? |
Any comments on this, otherwise I'll ask for help from @stain to do a patch release so we no longer have misleading information on the spec. |
As mentioned in the call I think your branch changes are good. Because 1.1.1 will still be under same folder Could you update your branch to also update equivalently in Then as soon as that PR is merged I can do the formal tagging as |
I think it's still valuable to distinguish between Data and Contextual entitites, as highlighted in our draft RO-Crate paper - but from #125 discussion I agree we can broaden its scope so that (You could do this even before without violating anything, but this option was not emphasized) So the question then is what to type these types as - I would assume they would still be This is mostly covered in https://www.researchobject.org/ro-crate/1.1/data-entities.html#referencing-files-and-folders-from-the-root-data-entity but without example:
I think Perhaps for this 1.1.1 fix we don't need to add the non-file non-dataset example, but it would be good to make a new issue to capture such an example - it could for instance be a molecule acession and trajectory like https://bioexcel-cv19.bsc.es/#/browse/MCV1900002/overview - which includes PDB files, but is not just the set of files. (In fact the above should probably be a RO-Crate!) |
When/if we add #122 then we can also modify this introduction further to emphasize that any kind of entities can be gathered by the RO-Crate. |
Describe the bug
"RO-Crate method: “organizing file-based data with associated metadata, using linked data principles, in both human and machine readable formats, with the ability to include additional domain-specific metadata”"
Thise emphasises the file approach not the references. Without references it cannot support FDO and many other use cases.
That quote means that anyone not using files and not using data will tink RO-Crate is inappropriate. I can point to an entry in a database - that is not file-based data - it in Github. Linked Data principles is too obtuse - references needs to be explicit.
Its damaging, confusing and potentially will stop adoption and funding. Its also contrary to our presentations.
URL
https://www.researchobject.org/ro-crate/1.1/introduction.html
Suggested fix
update the text
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: