Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of section ## Web-based Data Entities #103

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Review of section ## Web-based Data Entities #103

merged 2 commits into from
Oct 22, 2020

Conversation

ljgarcia
Copy link
Contributor

  • Original text, line 193 "RO-Crates can also gather resources on the web". Proposed text "RO-Crates can also gather resources from the web". But I am not sure what you mean here. Is it gather as in collect? Or is it include pointers to resources on the web?
  • "traversal", line 288. Not sure traversal or transversal is intended here, in any case, should it not be before download as an adjective?

@ljgarcia
Review of section ## Web-based Data Entities
623c14d 
* Original text, line 193 "RO-Crates can also gather resources on the web". Proposed text "RO-Crates can also gather resources from the web". But I am not sure what you mean here. Is it gather as in collect? Or is it include pointers to resources on the web?
* "traversal", line 288. Not sure traversal or transversal is intended here, in any case, should it not be before download as an adjective?
@ljgarcia ljgarcia requested a review from stain September 30, 2020 11:22
@ljgarcia ljgarcia mentioned this pull request Sep 30, 2020
Closed
10 tasks
@stain stain merged commit 987a9f3 into master Oct 22, 2020
@stain
Copy link
Contributor

stain commented Oct 22, 2020

Thank you, @ljgarcia! I think RO-Crate gathering from the web is good - obviously resources external will stay where they are, yet by adding them in hasPart we are promoting them from not just being something out there to also being included as a part of composing this RO for whatever reason. So it is in a sense something between composition and reference!

@stain stain deleted the ljgarcia-patch-1 branch October 22, 2020 15:17
@stain stain added this to the RO-Crate 1.1 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stain stain stain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
RO-Crate 1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ljgarcia @stain