Wrong namespace in PCDM links #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. the namespaced terms don't use dates in the PCDM ontology. The context.jsonld was correct, only the HTML description of that mapping was wrong. Added link to the PCDM version in paragraph above. Also fixes @jmfernandez comment #109 (comment) that RepositoryFile incorrectly mapped to pcdm:Collection instead of pcdm:File Improve description of RepositoryObject/RepositoryColletion rename by also noting RepositoryFile was renamed. Addresses @ptsefton #109 (comment) and #109 (comment)
stain
force-pushed
the
pcdm-namespaces
branch
from
26baec6
to
8e543e1
Compare
jmfernandez
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. the namespaced terms don't use dates in the PCDM ontology. The context.jsonld had correct mapping, only the HTML description of that mapping was wrong.
So https://pcdm.org/2016/04/18/models#hasFile should be http://pcdm.org/models#hasFile etc.
Added link to the PCDM version https://pcdm.org/2016/04/18/models in paragraph above.
Also fixes @jmfernandez comment #109 (comment)
that
RepositoryFileincorrectly mapped topcdm:Collectioninstead ofpcdm:FileImprove description of
RepositoryObject/RepositoryColletionrename by also notingRepositoryFilewas renamed.This also address @ptsefton #109 (comment) and #109 (comment) about
(PCDM))and<del>