Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter evaluations endpoint by ground truth #110

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Filter evaluations endpoint by ground truth #110

merged 5 commits into from
Nov 14, 2022

Conversation

mvandenburgh
Copy link
Member

Only adds parameters to server endpoint, the frontend changes will follow in another PR.

@mcovalt
Copy link
Contributor

mcovalt commented Nov 7, 2022

Looks good! I'll approve after the dependent branch paginate-site-evaluations gets merged. I believe GitHub will automatically update this PR to merge into phase-ii after that.

Base automatically changed from paginate-site-evaluations to phase-ii November 8, 2022 18:27
@mvandenburgh mvandenburgh requested a review from mcovalt November 8, 2022 19:26
mcovalt
mcovalt suggested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@mcovalt mcovalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a simple bug. On a request to /api/evaluations?performer=KIT I get a malformed "next" link: /api/evaluations?performer=KIT?performer=KIT&page=2.

@mvandenburgh
Copy link
Member Author

I noticed a simple bug. On a request to /api/evaluations?performer=KIT I get a malformed "next" link: /api/evaluations?performer=KIT?performer=KIT&page=2.

Fixed 👍

@mvandenburgh mvandenburgh requested a review from mcovalt November 10, 2022 15:59
@mvandenburgh mvandenburgh merged commit 8d61b67 into phase-ii Nov 14, 2022
@mvandenburgh mvandenburgh deleted the filter-ground-truth-evaluations-endpoint branch November 14, 2022 21:20
@mcovalt mcovalt mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcovalt mcovalt mcovalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvandenburgh @mcovalt