Misc fixes/improvements to ingest endpoint #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryonLewis
approved these changes
May 23, 2024
mvandenburgh
force-pushed
the
ingest-improvements
branch
from
6f090d4
to
4c59694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues I noticed while debugging the bug David reported about 500 errors on model run upload.
Performermodel, allow creation of new performers #407, new performers can be created. But, the pydantic validation for site/region models still restricts the list of accepted performers.GEOSException. We don't explicitly catch it currently, resulting in a 500 error.