Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for viewing local geojson layers #524

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

floryst
Copy link
Contributor

@floryst floryst commented Oct 22, 2024

Users can now visualize local geojson files in RD-WATCH.

Screen.Recording.2024-10-22.at.3.19.43.PM.webm

Nice-to-haves and other considerations:

  • toggle layer visibility
  • nicer layer names (based on what?)
  • edit geometry styles
  • should the annotator view also support viewing local geojsons?

Other changes:

  • The map is no longer partially covered by the sidebar
  • An event is used for triggering map.fitBounds() instead of a state variable
  • minor whitespace changes that were automatically done by my editor

Copy link
Contributor

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay in reviewing this, just a couple of suggestions.

As usual some future features not needed for this PR (mostly just thoughts):

  • May be nice to integrate with tooltips and present a table of the properties for a feature, or perhaps selection and provides a table of the properties for the selected features. There could be metadata associated with their geometry that help distinguish items.

vue/src/components/MapLibre.vue Outdated Show resolved Hide resolved
vue/src/components/LocalLayers.vue Show resolved Hide resolved
vue/src/components/LocalLayers.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants