Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pest instead of PHPT files #1495

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

henriquemoody
Copy link
Member

@henriquemoody henriquemoody commented Dec 16, 2024

Although I love PHPT files, and I've done my fair share of making it easier to write them in this library, they're very slow, and running them has become a hindrance.

I've been fidgeting with the idea of using Pest for a while, and I think it's the right tool for the job. I had to create a couple of functions to make it easier to run those tests, and now they're working really alright.

I migrated all the PHPT files into Pest files -- I automated most of the work with a little script using "nikic/php-parser"; this commit should contain all the previous PHPT tests as Pest tests.

The previous integration tests would take sixteen seconds, and the Pest tests take less than a second.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (ea29c2c) to head (94daa8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1495      +/-   ##
============================================
- Coverage     97.36%   96.55%   -0.81%     
  Complexity      967      967              
============================================
  Files           200      200              
  Lines          2354     2354              
============================================
- Hits           2292     2273      -19     
- Misses           62       81      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquemoody henriquemoody force-pushed the core/pest branch 5 times, most recently from 01d41c7 to 6788c8d Compare December 16, 2024 16:07
Although I love PHPT files, and I've done my fair share of making it
easier to write them in this library, they're very slow, and running
them has become a hindrance.

I've been fidgeting with the idea of using Pest for a while, and I think
it's the right tool for the job. I had to create a couple of functions
to make it easier to run those tests, and now they're working really
alright.

I migrated all the PHPT files into Pest files -- I automated most of the
work with a little script using "nikic/php-parser"; this commit should
contain all the previous PHPT tests as Pest tests.

The previous integration tests would take sixteen seconds, and the Pest
tests take less than a second.
@henriquemoody henriquemoody merged commit 94daa8d into Respect:main Dec 16, 2024
8 checks passed
@henriquemoody henriquemoody deleted the core/pest branch December 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant