perf(user): hide completion progress behind authentication (#1812)

RetroAchievements · Sep 1, 2023 · 9128fc7 · 9128fc7
1 parent 6baf300
commit 9128fc7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/app/Helpers/database/user.php b/app/Helpers/database/user.php
@@ -159,7 +159,7 @@ function getUserActivityRange(string $user, ?string &$firstLogin, ?string &$last
     return false;
 }
 
-function getUserPageInfo(string $user, int $numGames = 0, int $numRecentAchievements = 0): array
+function getUserPageInfo(string $user, int $numGames = 0, int $numRecentAchievements = 0, bool $isAuthenticated = false): array
 {
     if (!getAccountDetails($user, $userInfo)) {
         return [];
@@ -186,7 +186,8 @@ function getUserPageInfo(string $user, int $numGames = 0, int $numRecentAchievem
 
     $libraryOut['Rank'] = getUserRank($user);
 
-    $libraryOut['RecentlyPlayedCount'] = getRecentlyPlayedGames($user, 0, $numGames, $recentlyPlayedData);
+    $recentlyPlayedData = [];
+    $libraryOut['RecentlyPlayedCount'] = $isAuthenticated ? getRecentlyPlayedGames($user, 0, $numGames, $recentlyPlayedData) : 0;
     $libraryOut['RecentlyPlayed'] = $recentlyPlayedData;
 
     if ($libraryOut['RecentlyPlayedCount'] > 0) {

diff --git a/public/API/API_GetUserSummary.php b/public/API/API_GetUserSummary.php
@@ -92,7 +92,7 @@
 $recentGamesPlayed = (int) request()->query('g', '5');
 $recentAchievementsEarned = (int) request()->query('a', '10');
 
-$retVal = getUserPageInfo($user, $recentGamesPlayed, $recentAchievementsEarned);
+$retVal = getUserPageInfo($user, $recentGamesPlayed, $recentAchievementsEarned, true);
 
 if (empty($retVal)) {
     return response()->json([

diff --git a/public/userInfo.php b/public/userInfo.php
@@ -20,7 +20,7 @@
 
 $maxNumGamesToFetch = requestInputSanitized('g', 5, 'integer');
 
-$userMassData = getUserPageInfo($userPage, numGames: $maxNumGamesToFetch);
+$userMassData = getUserPageInfo($userPage, numGames: $maxNumGamesToFetch, isAuthenticated: $user !== null);
 if (empty($userMassData)) {
     abort(404);
 }
@@ -52,7 +52,7 @@
 $totalSoftcoreAchievements = 0;
 
 // Get user's list of played games and pct completion
-$userCompletedGamesList = getUsersCompletedGamesAndMax($userPage);
+$userCompletedGamesList = $user ? getUsersCompletedGamesAndMax($userPage) : [];
 
 $excludedConsoles = ["Hubs", "Events"];
 
@@ -630,7 +630,10 @@ function resize() {
         $prefersHiddenUserCompletedSets = request()->cookie('prefers_hidden_user_completed_sets') === 'true';
 
         RenderSiteAwards(getUsersSiteAwards($userPage), $userPage);
-        RenderCompletedGamesList($userCompletedGamesList, $userPage, $prefersHiddenUserCompletedSets);
+
+        if (count($userCompletedGamesList) >= 1) {
+            RenderCompletedGamesList($userCompletedGamesList, $userPage, $prefersHiddenUserCompletedSets);
+        }
 
         echo "<div id='achdistribution' class='component'>";
         echo "<h3>Recent Progress</h3>";