Show count of tickets for dev in game list #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Apr 29, 2023
I think it should be a single link. I'm undecided whether it should link to the user's tickets for the game, or just all tickets for the game. I'm leaning towards the second |
Jamiras
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar update as the Leaderboard change to now show the number of tickets from the dev vs the total tickets for the set. As with that change the total reflected at the bottom will be just for the dev though these totals could potentially also show dev vs total if desired
The value on the left will filter tickets to just the dev while the one on the right will show all tickets for the game.
Not fully set on this method vs just showing the full
X of Yas a single hyperlink or taking off the dev hyperlink when the dev has0 of Ytickets so I'm open to updating if this implementation is not ideal