feat(user): persist the hide completed sets checkbox #1521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the "Hide completed sets" checkbox to enable cookie-driven persistence.
Summary of changes:
hidden
Tailwind class.@/
import path defined in the tsconfig. This also was conflicting with a linting rule which did not understand tsconfigbaseUrl
andpaths
values. This has been remediated by addingeslint-import-resolver-typescript
to the eslint import resolver settings.toggleUserCompletedSetsVisibility()
is no longer being lazy-loaded. It is small enough that lazy loading it hurts performance more than helps it. As a result, I have moved it out of the dynamic folder and into the utils folder.ref: https://discord.com/channels/310192285306454017/1100897119709179915
This also resolves an issue where some browsers automatically set the checkbox on previous/next navigations, but the checkbox doesn't do anything. That issue should go away as a result of the changes in this PR.