Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(home): dont show duplicate user+game pairs in new sets/revisions #1536

Merged

Conversation

wescopeland
Copy link
Member

This PR makes an adjustment to how the list of New Sets/Revisions are built on the home page.

Currently, it is possible for the same user+game pair to appear N times in the list. After this change, the "oldest" of these user+game pair duplicates will be the winner and the others will be ignored.

Before
Screenshot 2023-04-30 at 5 18 50 PM

After
Screenshot 2023-04-30 at 5 19 09 PM

Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like something that should be done at the query level, but it's probably not that common to worry about.

If the two duplicate records were the last visible record and the first offscreen record, only the newer information would be presented.

@Jamiras Jamiras merged commit 9269fe9 into RetroAchievements:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants