Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reorderSiteAwards): make some minor improvements to desktop ux #1543

Merged

Conversation

wescopeland
Copy link
Member

This PR makes a few minor adjustments to the reorder site awards UX. The changes are most impactful on desktop.

Summary of Changes

  • A minor bug has been fixed where manual move buttons were hidden when the "Hidden" checkbox was ticked, but not truly disabled.
  • The rows themselves are now more compact, allowing a user to see more of them (and thus, drag and drop farther) on the screen.
  • The page now auto-scrolls when the user is dragging and holds their cursor near the top or bottom edges of the window.
  • A new "Hide saved hidden rows" checkbox has been added to the top of the page. When checked, saved hidden rows will be given a hidden class, rendering them invisible.

From a technical implementation standpoint, I figured it also made sense to start separating out the single reorderSiteAwards.ts file into multiple small utils. Almost everywhere I have changed something, I have done this. As a result of moving the original file, the adds/deletes on this PR are much larger than the actual code that has been contributed and removed. This will make future enhancements I have planned a bit easier to write. I would also like to add tests, and those will be easier to develop once everything is broken out.

Awards Size Before
Awards Size Old

Awards Size After
Awards Size New


New.Recording.May.01.2023.0851.PM.mp4

Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I missed a post-checkout command, but none of the reordering buttons seem to do anything for me. Drag/drop and hide do work.

public/reorderSiteAwards.php Outdated Show resolved Hide resolved
@wescopeland wescopeland requested a review from Jamiras May 5, 2023 18:16
@Jamiras Jamiras merged commit a1e7e9d into RetroAchievements:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants