-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reorderSiteAwards): make some minor improvements to desktop ux #1543
Merged
Jamiras
merged 12 commits into
RetroAchievements:master
from
wescopeland:improved-desktop-reordering
May 5, 2023
Merged
feat(reorderSiteAwards): make some minor improvements to desktop ux #1543
Jamiras
merged 12 commits into
RetroAchievements:master
from
wescopeland:improved-desktop-reordering
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opeland/RAWeb into improved-desktop-reordering
Jamiras
reviewed
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I missed a post-checkout command, but none of the reordering buttons seem to do anything for me. Drag/drop and hide do work.
Jamiras
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor adjustments to the reorder site awards UX. The changes are most impactful on desktop.
Summary of Changes
hidden
class, rendering them invisible.From a technical implementation standpoint, I figured it also made sense to start separating out the single reorderSiteAwards.ts file into multiple small utils. Almost everywhere I have changed something, I have done this. As a result of moving the original file, the adds/deletes on this PR are much larger than the actual code that has been contributed and removed. This will make future enhancements I have planned a bit easier to write. I would also like to add tests, and those will be easier to develop once everything is broken out.
Awards Size Before
Awards Size After
New.Recording.May.01.2023.0851.PM.mp4