Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remediate erroneous white space in game and ach shortcode rendering #1544

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented May 2, 2023

Resolves #1509.

This is caused by the browser not trimming the extra whitespace when the shortcodes are rendered in a <pre> tag.

Before
(notice the space between the console name and game name on the first entry)
Screenshot 2023-05-01 at 11 11 01 PM

Screenshot 2023-05-02 at 1 54 50 PM

After
Screenshot 2023-05-01 at 11 10 24 PM

Screenshot 2023-05-02 at 1 54 41 PM

@wescopeland wescopeland marked this pull request as ready for review May 2, 2023 14:48
@wescopeland wescopeland changed the title fix(renderGameTitle): remediate erroneous white space fix: remediate erroneous white space in game and ach shortcode rendering May 2, 2023
@wescopeland wescopeland requested a review from Jamiras May 5, 2023 18:30
@Jamiras Jamiras merged commit 8360cff into RetroAchievements:master May 5, 2023
@wescopeland wescopeland deleted the fix-game-avatar-double-space branch May 5, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double Space in Game-Tag referencing Subsets
2 participants