New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(globalRanking): Rank column shows your rank as being 0 when using the Followed Users filter and browsing pages past your actual rank #1562

Merged

Jamiras merged 2 commits into RetroAchievements:master from cIymax:patch-6

May 9, 2023

Contributor

cIymax commented May 7, 2023 •

edited

Loading

Highlights

This PR attempts to fix an issue with the Rank column on the global ranking page using the Followed Users filter and when browsing pages past your actual rank.
The issue was first described in the latter part of #1088 as quoted below.

Self rank among followed users is not correctly displayed when you move to

Considerations

Because my RAWeb test server is not fully set up, I'm submitting this untested on my part. Any feedback/assistance would be greatly appreciated.
The other issue described in the former part of #1088 is addressed by #1561.


          Update globalRanking.php

d5d0c98

Jamiras approved these changes

View reviewed changes

Member

Jamiras commented May 9, 2023

Because my RAWeb test server is not fully set up, I'm submitting this untested on my part. Any feedback/assistance would be greatly appreciated.

Please do not submit untested PRs. If you need help getting your test server set up, seek it.


          Merge branch 'master' into patch-6

65b54c8

Jamiras merged commit dc51262 into RetroAchievements:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet