Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codenotes): remediate issue with cancel restore linebreaks #1564

Merged

Conversation

wescopeland
Copy link
Member

Resolves #1563.

In the original code, the .replace() function was looking for a <br> element followed by a newline character (\n). However, it is possible for the input string to contain <br> elements that are not always followed by a newline character. This inconsistency caused the line breaks to not be properly restored when the user cancelled editing a code note.

@Jamiras Jamiras merged commit a9d9228 into RetroAchievements:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<br> displayed when editing Code Notes on Site
2 participants