Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setRequestList): add new filter and update filters UX #1574

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented May 10, 2023

This PR revises the set request list page filters UX via a Blade migration and adds an additional filter to see all, only claimed, or only unclaimed games.

ref: https://discord.com/channels/310192285306454017/1105656936998903838


New.Recording.May.10.2023.0918.PM.mp4

@EmoonX
Copy link
Contributor

EmoonX commented May 10, 2023

How about a selector for the values All/Claimed/Unclaimed instead? I can think of the usefulness of having an option to see just already claimed sets. Plus those UI features feel better when applied symmetrically, IMO.

@wescopeland wescopeland changed the title feat(setRequestList): add 'Show only unclaimed games' filter feat(setRequestList): add new filter and update filters UX May 11, 2023
@wescopeland wescopeland requested review from Tsearo and EmoonX May 11, 2023 01:20
@wescopeland
Copy link
Member Author

I have revised the UX for this PR and migrated the filters panel to Blade.

@wescopeland wescopeland requested a review from Jamiras May 23, 2023 20:58
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving functionality. I would like to get @luchaos's opinion on blade migration and UX layout.

@Jamiras Jamiras requested a review from luchaos May 25, 2023 16:38
@wescopeland
Copy link
Member Author

@luchaos @Jamiras This branch has been updated to resolve all outstanding conflicts with V3.

@wescopeland wescopeland requested a review from Jamiras June 30, 2023 12:51
@Jamiras Jamiras merged commit df6483c into RetroAchievements:master Jun 30, 2023
5 checks passed
@wescopeland wescopeland deleted the add-show-unclaimed-only-filter branch June 30, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants