fix(createmessage): remediate html structure issue #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
May 23, 2023
|
You are correct, they were not nested at different levels. There is something going on in PHP's/Laravel's server-side renderer that I do not understand. The bug can be directly observed in the browser dev tools:
Nesting a form tag within a table tag is perfectly valid HTML, but the output structure by the server is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remediates an issue reported here: https://discord.com/channels/310192285306454017/1106029608408723486
Root Cause
The HTML structure for createmessage.php is invalid. Right now, the entire form renders outside its
<form>tag.