fix: never show empty error alerts #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remediates an issue that I am often able to reproduce on iOS Safari: every now and then when swiping through pages, an empty error alert appears at the top of the screen and doesn't leave.
This can occur for desktop users too, see #1427.
I suspect this is occurring because Safari will leave an idle tab running on the home page which causes issues with the Active Players widget, however that is just a working theory for now. When actively trying to repro the issue, I can't. It happens fairly often though when I'm mindlessly thumbing through the site.
I've also added trace logging so if this case occurs we can see exactly where it's coming from.
Resolves #1427.