fix(main.blade.php): use alternative solution for minimizing layout shift #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes max-width in favor of swapping the position of the
<article>and<aside>tags in the template. This has the benefit of remediating layout shift on the home page while also getting fluid layouts to work (/demo).Why this works
The layout shift on the home page is caused by the Active Players widget's
<script>tag, which the browser loads synchronously. During loading, HTML parsing is blocked and the browser renders the content available in that frame, which just happens to be missing the right-hand column. This is what is causing the layout shift on the home page.This solution remediates the issue by forcing the browser to parse the right-hand column first.