-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooltip): capture mouse coordinates on mouseover events #1696
fix(tooltip): capture mouse coordinates on mouseover events #1696
Conversation
@Jamiras To confirm, is this also happening locally with this branch (want to know if resolved by this conditional https://github.com/RetroAchievements/RAWeb/pull/1696/files#diff-240d4470ee3ede50a8ab91e0f5db2692756d9e8c9311ae74060c94cca2fa695bR38)? |
Yes, the user tooltip issue is happening on both master and the branch. |
Okay, I've been banging around on that page and I've just pushed a commit to fix the reported issue & another race condition I found with these dynamic tooltips where they sometimes would freeze onto the page if the user moused away too quickly. Let me know if things look any better on your end now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed functionality on user awards (original issue) and user tooltips on claims and recent posts (secondary issue).
Resolves https://discord.com/channels/310192285306454017/1133391926402490388.
Root Cause
When landing on a tooltipped element using only the mouse wheel and no mouse movement, an
onmouseover
event is fired to pop the tooltip. However, the event is not capturing the mouse coordinates, resulting in the tooltip to be incorrectly positioned on the top left corner of the screen.To resolve the issue, the mouse coordinates are now captured and utilized correctly.