fix(layout): prevent layout shift with sidebars #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply `lg:grid grid-cols-[1fr_340px] gap-4` in top brand, nav, and main content areas. Prevents layout shift and works with wide layouts (see /demo).
|
Not sure if intentional, but noticed a subtle change. The sidebar now extends the full height of the left container. I don't think this is the end of the world, just want to call it out in case it was unintended.
|
whops, thanks! i shouldn't have removed |
wescopeland
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
lg:grid grid-cols-[1fr_340px] gap-4in top brand, nav, and main content areas.Prevents layout shift and works with wide layouts (see /demo).