perf: aggressively cache getUsersCompletedGamesAndMax #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching to the Awarded data retrieved from the
getUsersCompletedGamesAndMax()call on user profiles.The cache is populated on page load, and busted when the user unlocks an achievement or resets progress.
If cached data is present, a lightweight query runs instead and the cached data is merged onto the lightweight fetch results.
Benchmarks
These benchmarks are taken with the local MySQL cache disabled.
User: televandalist
Speedup Factor: ~38x
User: CobaltZeroni
Speedup Factor: ~15x