perf(tooltip): use explicit event listeners #1733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a UI deadlock on the homepage for any browser that does not support
requestIdleCallback()
. Currently on these browsers, such as iOS Safari, the home page freezes for a few seconds before the user is able to do anything.Root Cause
The Active Players widget has 2 tooltipped elements for every row on the table. Tooltipped elements are manually attaching event listeners right now when they're added to the DOM. Because this is happening thousands of times on the home page, it's causing the page to freeze until the work is done.
Resolution
The tooltip code has been refactored to a formal Alpine.js component. Tooltip consumers are now responsible for manually attaching their required event listeners.
There are some other cleanup tasks I took care of while finishing this work: