fix(achievement): dont save type: none as an empty string [V3.2.1] #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
changed the title
Tsearo
reviewed
Aug 12, 2023
There was a problem hiding this comment.
Fixes when updating the type back to None or when creating a new achievement so looks good to me.
I may suggest having someone with root access running the following query to make sure there isn't any data discrepancy in the table from before this PR goes in as any achievements created between or set to None will be a blank string as opposed to NULL
UPDATE Achievements SET type = NULL WHERE type = ''
luchaos
approved these changes
Aug 12, 2023
will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.