Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site-awards): filter out beaten games from awards displays [V3.2.1] #1749

Merged

Conversation

wescopeland
Copy link
Member

Resolves https://discord.com/channels/476211979464343552/1026595325038833725/1139786829290291241.

  • Ensures beaten games are being fetched properly by the all-purpose getUsersSiteAwards() function.
  • Ensures they're filtered out in the SeparateAwards() function so they don't increase the count of Site Awards on user profiles.

@wescopeland wescopeland requested a review from a team August 12, 2023 11:31
Copy link
Contributor

@Tsearo Tsearo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the count issue

@Tsearo Tsearo merged commit 289f8b5 into RetroAchievements:master Aug 12, 2023
5 checks passed
@wescopeland wescopeland deleted the beaten-game-awards-display-fix branch August 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants