chore(user): add data-* attrs to game awards for userscripts [V3.2.1] #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
changed the title
Tsearo
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the popular userscripts for the site depended on "seeing" the mastery dates statically rendered in the user profiles site awards. This no longer occurs because of the dynamic game cards not being initially available in the template.
To retain compatibility with these scripts,
data-gameidanddata-dateattributes have been added to the wrapper div around each award. The date is presented in the same format it was displayed as in the static cards.NOTE: I have communicated that the preferred solution is https://retroachievements-api-js.vercel.app/v1/users/get-user-awards.html.