Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: php8.2 upgrade #1760

Merged
merged 4 commits into from
Aug 16, 2023
Merged

chore: php8.2 upgrade #1760

merged 4 commits into from
Aug 16, 2023

Conversation

luchaos
Copy link
Member

@luchaos luchaos commented Aug 13, 2023

We're already running PHP 8.2 and Ubuntu 22.04 on our servers. This update reflect those changes in the application. To be able to upgrade to Laravel 10 and use real Enums we need 8.1+. 8.0 will be EOL (end of life) in two months.

Note: a composer update to pull in PHP 8.2 dependencies will follow in a separate PR because it will require some changes.

Please update your local environment:

  • XAMPP/LAMPP/WAMPP: re-install/update
  • Docker: sail up
  • Valet: valet use 8.2 or valet isolate php@8.2
  • VM/WSL/Ubuntu: dist-upgrade to 22.04 (optional, i think. please verify)

We're already running PHP 8.2 and Ubuntu 22.04 on the server.
This update reflect those changes in the application.
To be able to upgrade to Laravel 10 and use Enums we need 8.1+.
8.0 will be EOL (end of life) in two months.

Note: composer update to pull in PHP 8.2 dependencies will follow in a
separate PR because it will require some changes.

Please update your local environment:
- Ubuntu 20.04 in VM: dist upgrade
- XAMPP/LAMPP/WAMPP: re-install/update
- Docker: `sail up`
- Valet: `valet use 8.2` or `valet isolate php@8.2`
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that running composer setup and sail up work great. I had no issues upgrading and visiting numerous pages on the site.

@luchaos
Copy link
Member Author

luchaos commented Aug 15, 2023

Verified that running composer setup and sail up work great. I had no issues upgrading and visiting numerous pages on the site.

Fantastic, thanks for confirmation!
I have it running with a hybrid Valet and Docker/Sail setup on macOS so that's definitely working, too.

Let's wait for some feedback from Windows/Linux users before merging. Maybe those setups require more steps that should be documented.

@luchaos
Copy link
Member Author

luchaos commented Aug 16, 2023

Thinking about it - this update does not require anyone to upgrade to php 8.2 yet. changing the minimum php version requires everybody to upgrade.
Upcoming dependency updates will. Until then we can figure out any setup issues on other systems.

@luchaos luchaos merged commit 939c9e4 into RetroAchievements:master Aug 16, 2023
5 checks passed
@luchaos luchaos deleted the php82 branch August 16, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants