chore: normalize buttons #1774
Merged
chore: normalize buttons #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize button usage: - No `<input type="submit">` - No `<button type="submit">` (`submit` is implicit) - No implicit styling of `<button>` (relevant for upcoming PRs)
luchaos
commented
Aug 17, 2023
wescopeland
reviewed
Aug 17, 2023
wescopeland
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the first components PRs extracted from the prototype/preview branch.
Normalize button usage:
<input type="submit"><button type="submit">(submitis implicit)<button>(relevant for upcoming PRs)type="button"That's the third or fourth time I'm normalizing those buttons now 🤔
I hope this time it sticks 😅