Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navbar blade components #1776

Merged
merged 29 commits into from
Sep 1, 2023
Merged

Conversation

luchaos
Copy link
Member

@luchaos luchaos commented Aug 17, 2023

  • Port navbar to blade components
  • (Re)introduce dropdown components
  • Adjustments for small screens (can certainly be improved)
  • Adjust policies to move blade components and controllers to model abilities (@can() and authorize())
  • Add point variants to navbar

Most of these changes are in preparation for the introduction of the permission matrix and getting rid of the user top card on sub-pages, hence moving point variants to navbar, too.

Increased font size, 4 columns in "Games", ported system icons:
Screenshot 2023-08-18 at 01 26 31

Search input expands on focus, no input on small screens (links to search page instead):
Screenshot 2023-08-18 at 01 26 55

Manage dropdown:
Screenshot 2023-08-18 at 01 27 12

"My pages" dropdown moved to profile menu with avatar:
Screenshot 2023-08-18 at 01 27 21

Small screen variants:
Screenshot 2023-08-18 at 01 35 23
Screenshot 2023-08-18 at 01 35 32
Screenshot 2023-08-18 at 01 35 43

Port navbar to blade components.
(re)introduce dropdown components.
@wescopeland wescopeland self-assigned this Aug 17, 2023
@wescopeland

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@wescopeland

This comment was marked as resolved.

@wescopeland

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@wescopeland

This comment was marked as resolved.

@luchaos
Copy link
Member Author

luchaos commented Aug 18, 2023

This is way better. I use search on my tablet all the time. The only thing I'm noticing now is things get a bit wonky on iPhone SE. Other iPhone sizes all work great though.

Targeting iPhone SE's 375px viewport with 1,000,000 points in: 6bb3605

@wescopeland

This comment was marked as off-topic.

@wescopeland

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@wescopeland

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@wescopeland

This comment was marked as outdated.

@Tsearo
Copy link
Contributor

Tsearo commented Aug 18, 2023

I wasn't able to reproduce the nav bar error at first but then tried a few different device sizes and could reproduce with Nest Hub Max (1280x800) at 95% zoom (100% zoom did not have the effect)

@wescopeland wescopeland dismissed their stale review August 28, 2023 15:34

Will re-review later today

@wescopeland

This comment was marked as resolved.

@luchaos

This comment was marked as resolved.

@luchaos luchaos merged commit a73d395 into RetroAchievements:master Sep 1, 2023
5 checks passed
@luchaos luchaos deleted the blade-navbar branch September 1, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants