feat(game): add beaten game credit dialog [progression] #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Aug 28, 2023
resources/views/platform/components/modal-content/beaten-game-credit.blade.php
Show resolved
Hide resolved
|
If there is only 1 Win Condition, the dialog now it shows as Progression. This change was made after the latest community and dev feedback. |
|
Resolved conflicts & added pluralization to the dialog. This should be all set now. Because this is only accessible behind elements that are feature-flagged, this is safe to merge. |
Jamiras
reviewed
Sep 3, 2023
resources/views/platform/components/modal-content/beaten-game-credit.blade.php
Outdated
Show resolved
Hide resolved
…eland/RAWeb into beaten-game-credit-dialog
Jamiras
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is a child of #1802. It contains all of the changes of #1802, and more.
This PR adds the new Beaten Game Credit dialog component, proposed in https://discord.com/channels/476211979464343552/1142257722788679780/1142258738946916482.
This dialog can be opened by tapping on the type indicator on game page achievement rows. Later, the intent is for it to also be opened in the game page progression component (#1785).
Implementation Details:
<x-modal-trigger />has been modified to allow content to be loaded dynamically.<x-modal-trigger />has also been modified to allow for a custom slot such that anything can be a modal trigger rather than the default "btn"-classed<button>.Dialog.Desktop.mp4
Dialog.Mobile.mp4