Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for feature flags #1811

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented Aug 27, 2023

This PR adds support for feature flags, as well as adds a new Blade directive: @hasfeature().

Assuming this is approved+merged, I'll begin adding feature flag-driven conditional rendering to the progression PRs so they can be merged but not yet enabled.

@wescopeland wescopeland requested review from luchaos and a team August 27, 2023 23:15
Copy link
Member

@luchaos luchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

app/Site/AppServiceProvider.php Show resolved Hide resolved
resources/views/demo.blade.php Outdated Show resolved Hide resolved
@wescopeland wescopeland merged commit 6baf300 into RetroAchievements:master Aug 28, 2023
5 checks passed
@wescopeland wescopeland deleted the add-feature-flags-support branch August 28, 2023 12:32
luchaos added a commit to luchaos/RAWeb that referenced this pull request Sep 2, 2023
fix: disable submit button when exceeding counter maxlength (RetroAchievements#1790)

fix(tooltip): track mouse position properly with static tooltips (RetroAchievements#1801)

fix(testBeatenGame): remove activity tracking (RetroAchievements#1797)

fix(devbox): remediate claims js errors (RetroAchievements#1808)

Add upgrade doc for 3.x -> 3.3

Fix composer dependencies for PHP 8.2 and relative symlinks

`artisan ra:storage:link --relative`

feat: add support for feature flags (RetroAchievements#1811)

Address feedback

Forum Verification

perf(user): hide completion progress behind authentication (RetroAchievements#1812)

Add auth, notifications, and messages to navbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants