-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for feature flags #1811
Merged
wescopeland
merged 6 commits into
RetroAchievements:master
from
wescopeland:add-feature-flags-support
Aug 28, 2023
Merged
feat: add support for feature flags #1811
wescopeland
merged 6 commits into
RetroAchievements:master
from
wescopeland:add-feature-flags-support
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Aug 27, 2023
luchaos
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
luchaos
approved these changes
Aug 28, 2023
luchaos
added a commit
to luchaos/RAWeb
that referenced
this pull request
Sep 2, 2023
fix: disable submit button when exceeding counter maxlength (RetroAchievements#1790) fix(tooltip): track mouse position properly with static tooltips (RetroAchievements#1801) fix(testBeatenGame): remove activity tracking (RetroAchievements#1797) fix(devbox): remediate claims js errors (RetroAchievements#1808) Add upgrade doc for 3.x -> 3.3 Fix composer dependencies for PHP 8.2 and relative symlinks `artisan ra:storage:link --relative` feat: add support for feature flags (RetroAchievements#1811) Address feedback Forum Verification perf(user): hide completion progress behind authentication (RetroAchievements#1812) Add auth, notifications, and messages to navbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for feature flags, as well as adds a new Blade directive:
@hasfeature()
.Assuming this is approved+merged, I'll begin adding feature flag-driven conditional rendering to the progression PRs so they can be merged but not yet enabled.