feat(game): allow sorting by achievement type #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsearo
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Works great 👍
Just a thought but would it make sense to hide the Type sort when there are no existing typed achievements? All of the other sorts always apply but this one is semi-conditional at least until all games are marked which may take some time after the feature goes live (and also for subsets which won't get marked). Likely not worth the effort but thought I'd at least bring it up
|
Yes, very good idea. We should make that change-- I'll update the code in this PR in just a bit. |
|
Conditional rendering logic added in eebadf4. |
Jamiras
reviewed
Sep 10, 2023
Jamiras
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sorting option to game pages: "Type", which orders achievements by Progression, Win Condition, and then
null.Brave.Browser.mp4