fix(game): show beaten progress on an optimistic basis #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
Rather than explicitly checking for the award, the status is rendered now on an optimistic basis dependent upon the user's current unlocks for the game.
It seems like it was doing that before.
The only changes I see here are calling testBeatenGame is dependent on the aggregate queries feature being disabled, and it will still check for a hardcore beaten badge if the softcore beaten badge was awarded. Otherwise, the functionality appears the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts how the progress component on game pages renders Beaten and Beaten (softcore) statuses.
Rather than explicitly checking for the award, the status is rendered now on an optimistic basis dependent upon the user's current unlocks for the game. This better facilitates self-healing of beaten game awards when async metrics aggregation is used.