Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid querying Activity table for recent logins #1905

Merged
merged 2 commits into from
Oct 7, 2023
Merged

avoid querying Activity table for recent logins #1905

merged 2 commits into from
Oct 7, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Oct 7, 2023 •
edited
Loading

should minimize login failures

[object] (Illuminate\\Database\\QueryException(code: HY000): SQLSTATE[HY000]: General error:
 3024 Query execution was interrupted, maximum statement execution time exceeded (SQL:
 SELECT * FROM Activity AS act
              WHERE act.ID =
                ( SELECT MAX(Activity.ID) FROM Activity WHERE Activity.user = :user AND Activity.activityType = 2 ) )
 at /home/forge/retroachievements.org/releases/2023-09-25T165924-4.1.0-97eec26c/vendor/laravel/framework/src/Illuminate/Database/Connection.php:760

@Jamiras Jamiras changed the base branch from master to release October 7, 2023 16:27
@Jamiras Jamiras changed the base branch from release to master October 7, 2023 16:28
@Jamiras Jamiras merged commit da3dea2 into RetroAchievements:master Oct 7, 2023
5 checks passed
@Jamiras Jamiras deleted the cache_last_login branch October 7, 2023 18:36
Jamiras added a commit that referenced this pull request Oct 7, 2023
@Jamiras
avoid querying Activity table for recent logins (#1905)
86eb693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luchaos luchaos luchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jamiras @luchaos