Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow activating aggregate queries with a cookie #1913

Merged

Conversation

wescopeland
Copy link
Member

This PR adds a middleware which allows a user to force-enable aggregate queries at the request level by having a cookie feature_aggregate_queries set to true.

It also adds a label for the feature flag to the <x-feature-flags /> component, which is visible on the admin panel.

Screenshot 2023-10-13 at 8 41 56 PM

@wescopeland wescopeland requested a review from a team October 14, 2023 00:43
@wescopeland
Copy link
Member Author

Screenshot 2023-10-14 at 8 36 48 AM
Screenshot 2023-10-14 at 8 36 36 AM

@wescopeland wescopeland merged commit 91cb74f into RetroAchievements:master Oct 14, 2023
5 checks passed
@wescopeland wescopeland deleted the aggregate-queries-cookie branch October 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants