Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use aggregated data for usergameactivity #1925

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Oct 24, 2023

Because this page no longer reads the Activity table, some historical data is lost. Sessions have to be generated only from unlock timestamps - we can no longer rely on the StartedPlaying Activity entries. Similarly, achievements that have been reset will no longer appear on the page as the historical unlock information is no longer available.

New sessions (created after v5 was deployed) should now be accurately captured instead of estimated.

For legacy data, the estimations are no longer as accurate. Here's one user playing an RPG:
image

Without the Activity table data, the same user/game:
image

7 sessions were extrapolated from the Activity table that contain no unlocks. These sessions would previously contribute to the overall time played through the estimated session extension logic. Similarly, without the StartedPlaying Activity entries, the lead up to the first achievement unlocked in a session is not captured (in this case it's almost two hours into the session):
image

As a result of the lead-up time missing, the session extension calculation is smaller, and without the "empty" sessions, the number of sessions that gets extended is smaller, which results in a much lower estimate (16 hours instead of 28).

Since it's just an estimate, we can't know which is more accurate. The loss of the lead-up time clearly makes the estimate too low, but the calculated session extension value could be overcorrecting for shorter sessions. And we have no idea whatsoever how long the sessions where achievements weren't earned were.

We want to get rid of the Activity table. Unfortunately, doing so does decrease the accuracy of the information provided on this page for historical data, but the newer data should be more accurate as it gets populated. Additionally, as this page is no longer database intensive, it might be possible to open it up to more users in the future.

@Jamiras Jamiras merged commit 65c4afc into RetroAchievements:master Oct 27, 2023
5 checks passed
@Jamiras Jamiras deleted the usergameactivity_aggregate branch October 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants