Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to mariadb and convert to utf8mb4 #1930

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat: switch to mariadb and convert to utf8mb4 #1930

merged 3 commits into from
Oct 27, 2023

Conversation

luchaos
Copy link
Member

@luchaos luchaos commented Oct 26, 2023 •
edited
Loading

Add the following to your .env until the mariadb utf8 dump is ready:

DB_CHARSET=latin1
DB_COLLATION=latin1_general_ci

Rebuilding docker containers is not advised yet as it will remove the mysql container from compose.

@luchaos luchaos marked this pull request as draft October 26, 2023 16:50
@luchaos luchaos marked this pull request as ready for review October 26, 2023 22:17
Jamiras
Jamiras approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified new database created by php artisan migrate:fresh --seed contains tables with DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci.

Though should it be utf8mb4_unicode_ci per the mysql.cnf?

@Jamiras
Copy link
Member

Jamiras commented Oct 26, 2023

Also verified explicitly setting DB_CHARSET fixes non-latin character display in existing dump.

@luchaos
Copy link
Member Author

luchaos commented Oct 26, 2023 •
edited
Loading

Though should it be utf8mb4_unicode_ci per the mysql.cnf?

mariadb uses general instead of unicode by default so the collation is set explicitly in the config with the latest commit.

@luchaos luchaos merged commit ea54e15 into RetroAchievements:master Oct 27, 2023
5 checks passed
@luchaos luchaos deleted the mariadb-utf8 branch October 27, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamiras Jamiras Jamiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luchaos @Jamiras