perf(navbar): don't eagerly load console icons #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the site is eagerly loading all console icons from the navbar, even if the user never opens the "Games" pane in the navbar.
On mobile with 4G conditions, this eager loading results in a ~1s longer overall page load time across the entire site due to hitting the browser's maximum connections limit. Render-blocking resources downstream are being delayed because of the max connections occupancy. The waterfall can be seen here: https://www.webpagetest.org/video/compare.php?tests=231030_BiDc3Y_EH4-r:3-c:0-e:filmstrip
After this PR, the icons will only load when the user opens the menu (or sees them elsewhere on the page).