Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix generating new forum topic for game #1986

Merged
merged 2 commits into from
Nov 5, 2023
Merged

fix generating new forum topic for game #1986

merged 2 commits into from
Nov 5, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Nov 5, 2023

fixes #1985

getGameMetadata(): Argument #2 ($user) must be of type ?App\\Site\\Models\\User, string given, called in
/home/forge/retroachievements.org/releases/2023-11-04T173719-5.1.1-8f93004d/app/Helpers/database/forum.php on line 417

also switches from getGameMetadata to Game::find as the achievement information is not needed.

wescopeland
wescopeland approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this resolves the issue.

@wescopeland

This comment was marked as duplicate.

Sign in to view
@Jamiras Jamiras merged commit 8dee27b into RetroAchievements:master Nov 5, 2023
5 checks passed
@Jamiras Jamiras deleted the fix_generate_forum_topic branch November 5, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wescopeland wescopeland wescopeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create fourm topic for claim
2 participants
@Jamiras @wescopeland