chore: add deprecation and authentication comments to dorequest #2120
Conversation
| case "allprogress": | ||
| $consoleID = (int) request()->input('c'); | ||
| $response['Response'] = GetAllUserProgress($username, $consoleID); | ||
| break; | ||
|
|
||
| // TODO deprecate - next image ID should be provided by the server |
There was a problem hiding this comment.
This is used by the DLL to determine the maximum value allowed for manually specifying a badge.
We could remove the validation and just allow the user to enter any number, but I'm not sure how well the client would handle the 404 response.
| case "gameid": | ||
| $md5 = request()->input('m') ?? ''; | ||
| $response['GameID'] = getGameIDFromMD5($md5); | ||
| break; | ||
|
|
||
| // TODO require authentication? |
There was a problem hiding this comment.
This is exposed through rcheevos without authentication. Clients would have to upgrade, though I'm not sure if any clients besides the DLL use it.
| case "gameslist": | ||
| $consoleID = (int) request()->input('c', 0); | ||
| $response['Response'] = getGamesListDataNamesOnly($consoleID); | ||
| break; | ||
|
|
||
| // TODO require authentication? |
There was a problem hiding this comment.
I'm not aware of any official uses for this. If it's being used by unofficial clients, we should provide a public API for this instead.
There was a problem hiding this comment.
This is indeed being used by third-party front-ends.
| case "officialgameslist": | ||
| $consoleID = (int) request()->input('c', 0); | ||
| $response['Response'] = getGamesListDataNamesOnly($consoleID, true); | ||
| break; | ||
|
|
||
| // TODO deprecate? |
There was a problem hiding this comment.
the functionality that used to rely on this was removed from the DLL in 0.76 (2019)
| @@ -277,6 +285,7 @@ function DoRequestError(string $error, ?int $status = 200, ?string $code = null) | |||
| $response['AchievementID'] = $achIDToAward; | |||
| break; | |||
|
|
|||
| // TODO deprecate | |||
There was a problem hiding this comment.
The DLL still uses this to show friend activity in the clients. It's buried in the overlay. I don't think I've ever used it. We could probably deprecate it.
to be discussed