refactor(LeaderboardDef): drop Author
#2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Jun 2, 2024
| addArticleComment("Server", ArticleType::Leaderboard, $idInOut, | ||
| "$author edited this leaderboard.", $author | ||
| "{$authorModel->display_name} edited this leaderboard.", $authorModel->username |
There was a problem hiding this comment.
Not sure if it matters, but edits from Connect use this message
And edits from the webpage use this one
There was a problem hiding this comment.
Probably not a huge deal if our long-term goal is to move over to the activitylog, but no harm in getting these consistent. Changed the webpage edits to match "edited this leaderboard".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last
Authorreads fromLeaderboardDefand drops the column. Additionally, eliminates some dead legacy code.