Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion-progress): make game rows expandable #2465

Conversation

wescopeland
Copy link
Member

This PR makes game rows on the Completion Progress page expandable, similar to the "Last N Games Played" rows on user profiles. This is achieved using a mix of Alpine.js and Livewire 3.

For the sake of performance:

  • The data is not loaded until the rows themselves are expanded.
  • While loading, a loading skeleton displays.
  • When data loading is complete, the browser waits for images to finish loading to try to achieve a clean cross-fade effect. If images are slow to load, after 1 second, the loader hides anyway.
Area.mp4

@wescopeland wescopeland requested a review from a team May 24, 2024 16:27
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified behavior. Did not dig into code.

@wescopeland wescopeland merged commit ec490f2 into RetroAchievements:master Jun 8, 2024
5 checks passed
@wescopeland wescopeland deleted the completion-progress-expandable-rows branch June 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants