refactor(game): migrate several helpers to eloquent orm #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Jun 17, 2024
app/Helpers/database/game.php
Outdated
|
|
||
| return true; | ||
| } | ||
|
|
||
| function getRichPresencePatch(int $gameID, ?array &$dataOut): bool | ||
| function getRichPresencePatch(int $gameId, ?array &$dataOut): bool |
There was a problem hiding this comment.
Changed to string in latest. This one escaped me - has this been incorrectly typed the whole time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates several of the key game modification helper functions to use Eloquent ORM queries. Currently, since these are making raw SQL calls to the DB, most model updates made by developers are not showing up in the game entity's activitylog in the management panel.