Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more detail in unlock history on ticket page #2507

Merged
merged 10 commits into from
Jun 20, 2024

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jun 17, 2024

Adds per-client usage rates to client summary on the ticket page (and the user game moderation page):
image

The unlock history is now grouped by session (showing the client used for each session):
image

Older tickets (submitted prior to capturing session information) show generated sessions. The "Generated Session" label has a tooltip to clarify what a generated session is:
image

Information showing when the ticket was created and when the associated achievement was unlocked is still injected into the history, including manual unlock information.
image

Also extracted a lot of logic from the ticket view page into a service.

app/Platform/Services/TicketService.php Outdated Show resolved Hide resolved
app/Platform/Services/TicketService.php Outdated Show resolved Hide resolved
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified UI/UX. Just a few more comments on the code.

app/Platform/Services/PlayerGameActivityService.php Outdated Show resolved Hide resolved
app/Platform/Services/TicketViewService.php Outdated Show resolved Hide resolved
@Jamiras Jamiras merged commit 334c1aa into RetroAchievements:master Jun 20, 2024
5 checks passed
@Jamiras Jamiras deleted the feature/ticket_client_usage branch June 20, 2024 13:53
@RetroAchievements RetroAchievements locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants