-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manage): add achievement relation manager for games #2516
feat(manage): add achievement relation manager for games #2516
Conversation
Drag and drop reorder doesn't seem to work for me. The cursor turns into a red NOT symbol (cursor doesn't appear in screenshot, so I can't really share). |
…land/RAWeb into game-achievement-manager
Those are the same roles my account has. Are you able to reproduce this issue in other browsers? I'm able to successfully drag+drop with Chrome and Firefox. I've also tested with multiple user accounts and multiple roles. Can you also try ensuring Vite is running? Can you try |
I get the same behavior in Chrome and Edge. Firefox doesn't give me the NO sign, but it doesn't seem to actually rearrange anything either. Output from provided commands:
I also see the same behavior logged in as your user (same set of roles) |
Understood, thank you for trying those things. There must be a difference between our two setups somewhere; I'm having a hard time right now thinking of what it might be. After #2502 is done using preview, maybe what would be best is to deploy this branch onto preview and see if the issue still surfaces in that environment. |
This PR ports most (all?) of the functionality from the achievement inspector to the management app.
Developers are able to:
Additionally, actions are guarded using the
AchievementPolicy
, ensuring that Jr Devs can't update things they're not supposed to be able to.The achievements are now listed on the game view page, eg:
/manage/games/1
.I wish there was a way to pop some kind of "Success!" confirm on reordering. Unfortunately, it doesn't look like Filament supports this.
Brave.Browser.mp4