Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manage): add memory notes management to game resources #2569

Merged

Conversation

wescopeland
Copy link
Member

This PR adds another relation manager to the management app's game resource. Now, developers can manage code notes from the game resource's page, similar to achievements and hashes. The intention is to fully mirror the code note management behavior in the player-facing app, and in a subsequent release have the functionality live exclusively in the management app.

There are a few minor behavior differences:

  • Only 200 code notes are loaded per page. This solves the Dragon Quest VIII problem where that game's code notes page will not load locally.
  • Users can now search for code notes via the body attribute.
  • Optionally, users can view a column for the updated_at value.
  • Users can filter by note author.

Screenshot 2024-07-21 at 4 36 40 PM

Screenshot 2024-07-21 at 4 36 45 PM

Screenshot 2024-07-21 at 4 36 52 PM

Screenshot 2024-07-21 at 4 36 59 PM

Screenshot 2024-07-21 at 4 37 07 PM

Screenshot 2024-07-21 at 4 37 11 PM

@wescopeland wescopeland requested a review from a team July 21, 2024 20:38
@wescopeland wescopeland merged commit 3b79ccd into RetroAchievements:master Jul 28, 2024
5 checks passed
@wescopeland wescopeland deleted the manage-game-memory-notes branch July 28, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants