-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow system to be enabled from management page #2578
Allow system to be enabled from management page #2578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested activating/deactivating various systems to confirm behavior through the various code changes is functioning correctly.
There's nothing in these changes that leaps out to me as a cause for concern. For the noted redundant queries, we'll inevitably clean that stuff up as the UI continues to evolve, especially with a future move to Inertia+React.
Without having to deploy anything.
Note: this just updates the menu and the
isValidConsole
checks to read from the database instead of a config file.The download page still requires new emulators to be registered in the
releases.php
file. New console IDs can be added to existing emulators and will be hidden until the console is activated.SQL to get DB in sync with seed file: