Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system to be enabled from management page #2578

Merged
merged 12 commits into from
Sep 7, 2024

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jul 26, 2024

Without having to deploy anything.

Note: this just updates the menu and the isValidConsole checks to read from the database instead of a config file.

The download page still requires new emulators to be registered in the releases.php file. New console IDs can be added to existing emulators and will be hidden until the console is activated.

SQL to get DB in sync with seed file:

UPDATE Console SET manufacturer='Microsoft' where ID=26;
UPDATE Console SET order_column=1 WHERE ID IN (4,12,25,33,8,56,34,54,29,31,64);
UPDATE Console SET order_column=2 WHERE ID IN (6,21,50,11,76,14,30,55,26,59,52);
UPDATE Console SET order_column=3 WHERE ID IN (5,41,51,15,67,22,35);
UPDATE Console SET order_column=4 WHERE ID IN (7,36,1,47);
UPDATE Console SET order_column=5 WHERE ID IN (3,17,9,48);
UPDATE Console SET order_column=6 WHERE ID IN (2,77,10,49);
UPDATE Console SET order_column=7 WHERE ID IN (16,13,39);
UPDATE Console SET order_column=8 WHERE ID IN (19,40);
UPDATE Console SET order_column=9 WHERE ID IN (20,68);
UPDATE Console SET order_column=10 WHERE ID IN (18);
UPDATE Console SET order_column=11 WHERE ID IN (78);
UPDATE Console SET order_column=12 WHERE ID IN (62);
UPDATE Console SET order_column=13 WHERE ID IN (24);
UPDATE Console SET order_column=14 WHERE ID IN (60);
UPDATE Console SET order_column=15 WHERE ID IN (28);
UPDATE Console SET active=1 WHERE ID IN (16,71,72,73,74,75,76,77,78,80,102);

@Jamiras Jamiras added the deployment/sql Includes SQL that needs to be run before/after deployment label Jul 26, 2024
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested activating/deactivating various systems to confirm behavior through the various code changes is functioning correctly.

There's nothing in these changes that leaps out to me as a cause for concern. For the noted redundant queries, we'll inevitably clean that stuff up as the UI continues to evolve, especially with a future move to Inertia+React.

@Jamiras Jamiras merged commit 10cdf9e into RetroAchievements:master Sep 7, 2024
5 checks passed
@Jamiras Jamiras deleted the feature/system_active branch September 7, 2024 22:46
@Jamiras Jamiras removed the deployment/sql Includes SQL that needs to be run before/after deployment label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants