-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manage): improve breadcrumbs usability #2595
feat(manage): improve breadcrumbs usability #2595
Conversation
…escopeland/RAWeb into achievement-manage-breadcrumbs
…escopeland/RAWeb into achievement-manage-breadcrumbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a default Filament behavior for users who have the ability to edit the resource. If the user doesn't have the ability to edit the resource, they'll instead be linked to the resource's "Details" (view) page. With that in mind, we should probably ensure both pages follow a similar layout & show the same fields. I'll make a note to circle back on this in a follow-up PR. |
Odd. The achievement links weren't directed to the edit page for the achievement, and I had permission to edit those too. |
Ah, that is because in AchievementsRelationManager.php, for some reason I put in an override: ->recordUrl(
fn (Achievement $record): string => route('filament.admin.resources.achievements.view', ['record' => $record])
) Now that you mention it, this should probably be removed as it creates an inconsistent user experience. |
Although, with that override removed, the table rows don't link anywhere at all. That must explain why I added it. |
I've made a change to those achievement rows in 2c80aa4 so we can have a consistent behavior. The rows now do a policy check to determine what the href should be. |
This PR slightly alerts the management app's achievement and leaderboard page breadcrumbs so the game is always in the list of links.
Before
After